kugel- requested changes on this pull request.


> @@ -192,6 +192,14 @@ static gboolean goto_file_pos(const gchar *file, gint 
> pos)
 void navqueue_go_back(void)
 {
        filepos *fprev;
+       GeanyDocument *doc = document_get_current();
+
+       /* If the navqueue is currently at some position A, but the actual 
cursor is at some other
+        * place B, we should add B to the navqueue, so that (1) we go back to 
A, not to the next
+        * item in the queue; and (2) we can later restore B by going forward.
+        * (If A = B, add_new_position will ignore it.) */
+       if (doc && doc->file_name)

The toolbar items are insensitive when there is no tabs, so this condition 
shouldn't be needed. The doc->file_name check may need to stay for unnamed docs.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#pullrequestreview-49965486

Reply via email to