techee commented on this pull request.


>               mods |= GEANY_PRIMARY_MOD_MASK;
+               mods &= ~GDK_MOD2_MASK;

I slightly prefer my version - it's a bit easier to understand (at least by my 
poor brain) and it's guaranteed to set/clear the bits while the XOR depends on 
the actual value of mods (but it probably won't contain GEANY_PRIMARY_MOD_MASK 
bit and is guaranteed to have GDK_MOD2_MASK set).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1636#discussion_r144418654

Reply via email to