b4n requested changes on this pull request.
For the WebHelper plugin: I think it's a good idea to get Webkit2 support, but
I think this needs more work to be mergeable.
> GdkPixbuf *icon;
-
- icon = gwh_pixbuf_new_from_uri (icon_uri, NULL);
+ GtkImage *image;
+ gtk_image_set_from_surface (image, favicon);
+ icon = gtk_image_get_pixbuf(image);
does this work? I would be highly surprised if it does, GtkImage is not
necessarily (well, I think never) using Pixbuf backed data, and so the
`get_pixbuf()` method will probably return `NULL` here, doesn't it?
> break;
case GDK_SCROLL_UP:
- webkit_web_view_zoom_in (WEBKIT_WEB_VIEW (self->priv->web_view));
+ webkit_web_view_set_zoom_level (WEBKIT_WEB_VIEW
(self->priv->web_view), 1.0);
this doesn't really make any sense, resetting the zoom to 1 when it should zoom
in/out
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/656#pullrequestreview-82318024
