Noticed with GCC 7 using `-Wall -Wextra -Wno-unused-parameter` warning options.
There's still a warning in `scintilla/src/Editor.cxx:205` but I left that for upstream to fix. For some reason the warning mentioned in Issue #1683 doesn't occur anymore here, so I didn't fix it. It would be great if someone could double-check the switch case fall-through changes to ensure I didn't actually mask real bugs, and that the bug I fixed in `keybindings.c` was actually correct. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1725 -- Commit Summary -- * Fix pointer and character constant comparison * Fix comparison between signed and unsigned integers * Fix missing initializer for field warnings * Fix missing initializer for field warnings in parsers * Adjust 'fall through' comments to be recognized by GCC * Add more 'fall through' comments for switch cases * Remove some unused variables * Fix comparison between signed and unsigned integers * Add 'fall through' comments and fix actual bug -- File Changes -- M ctags/main/parse.c (4) M ctags/main/xtag.c (10) M ctags/parsers/actionscript.c (20) M ctags/parsers/cobol.c (12) M ctags/parsers/fortran.c (4) M ctags/parsers/html.c (10) M ctags/parsers/perl.c (2) M ctags/parsers/r.c (1) M src/editor.c (7) M src/encodings.c (4) M src/highlighting.c (3) M src/keybindings.c (2) M src/search.c (1) M src/tools.c (1) -- Patch Links -- https://github.com/geany/geany/pull/1725.patch https://github.com/geany/geany/pull/1725.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1725
