LarsGit223 commented on this pull request.


> +static void connect_documents_button_press_signal_handler(AoColorTip 
> *colortip)
+{
+       guint i = 0;
+       /* connect the button-press event for all open documents */
+       foreach_document(i)
+       {
+               connect_document_button_press_signal_handler(colortip, 
documents[i]);
+       }
+}
+
+
+static void ao_color_tip_finalize(GObject *object)
+{
+       g_return_if_fail(object != NULL);
+       g_return_if_fail(IS_AO_COLORTIP(object));
+

I tested what @codebrainz described above and nothing happens. So I assume that 
everything is fine. If not I would have expected a crash if an old/invalid 
pointer would still be used.

Then I read @b4n's first comment again: AoColortip is only destroyed in 
function ```plugin_cleanup()```, so it should be OK.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/664#discussion_r161875401

Reply via email to