codebrainz commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
GEANY_KEYS_EDITOR_DELETELINETOBEGINNING, /**< Keybinding. */
+ GEANY_KEYS_DOCUMENT_STRIPTRAILINGSPACES, /**< Keybinding.
+
* @since 1.34 */
I like the current practice of putting both the Geany version and the API
version since as a plugin developer you're forced to know both and not have to
reverse engineer one from the other is useful (which is why this was started
IIRC). You need to know the Geany version to know which releases of Geany the
plugin is actually compatible with, but you also need to know the API version
to satisfy the `plugin_version_check()` thing in the plugin API.
In a perfect world we'd just get rid of the plugin API version and use only the
release version to make the whole concept simpler. I have [an old
commit](https://github.com/codebrainz/geany/commit/2a678cf0513fe7fd5163708c586adf5c545ed589)
that added this in a backwards compatible way. IIRC there was an objection
because of the theoretical case where some developer might want to use
intermediate API versions in-between release without having to keep their
feature branch up-to-date or something.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1806#discussion_r179649195
