I'm not 100% sure how easy it is to reapply commits that have been reverted, short of making sure they are different commits (as otherwise they are already merged), so it might be slightly annoying for that other Markdown PR.
Also, for WebHelper I don't really mind so long as the small problems gets fixed; I wanted to keep GTK2 support, but it's also true that in many recent distros (including next Debian) there is no more webkit1, so it's just not so useful anymore; and the delta between webkit1 and webki2 is bigger than a few GTK2/GTK3 conditionals. The only thing is that IIRC there are a few real issues with the webkit2 version that got merged, and it'd be sad to release with them, if they really exist. I might (or might not, no promises) have time to review and fix the issues before next release, but if people find and fix them already even better. My point is that the only thing that I really don't fancy with the merge are the potential bugs in the new version, not *so* much the drop of GTK2 support. But either way is good, and it'd be just fine for me to work on a new PR if this is reverted. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/749#issuecomment-394168578
