b4n requested changes on this pull request.

As mentioned, this would lead to not having any space between the dot and the 
next word, which is inappropriate.

> @@ -1949,7 +1949,7 @@ plugin_configure(GtkDialog * dialog)
        gtk_widget_set_tooltip_text(widgets.cb_editor_menu_entries,
                             _("Whether menu for this plugin are getting placed 
either "
                               "inside tools menu or directly inside Geany's 
menubar."
-                              "Will take in account after next start of 
GeanyVC"));
+                              " Will take in account after next start of 
GeanyVC"));

This is not appropriate: there should be a space between the dot and the next 
word, and the C string syntax `"xxx" "yyy"` is equivalent to `"xxxyyy"`, not 
`"xxx yyy"`.  If you really want to move the space, place it after the dot on 
the previous line.

> @@ -444,7 +444,7 @@ gboolean dialogs_workbench_settings(WORKBENCH *workbench)
        gtk_widget_set_tooltip_text(w_enable_live_update,
                _("If the option is activated (default), then the list of files 
and the sidebar"
                  " will be updated automatically if a file or directory is 
created, removed or renamed."
-                 "A manual re-scan is not required if the option is 
enabled."));
+                 " A manual re-scan is not required if the option is 
enabled."));

same here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/769#pullrequestreview-151371826

Reply via email to