It is not valid to place `AM_CONDITIONAL`s inside a shell condition, because 
Automake has to known its value in all cases.  Automake is smart enough to 
detect it if used in a AutoShell conditional (like `AS_IF`/`AS_CASE`/...), but 
can't work any magic inside a pure shell conditional (if/case/...). So, move 
the `AM_CONDITIONAL` outside the conditional, as the value is already 
conditional anyway.

This PR also cleans up the conditional a little bit by giving it a 
plugin-specific name, and removing irrelevant test fro the condition (whether 
or not the plugin is enabled has little to no relevance here, and the plugin 
won't be built anyway).
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/787

-- Commit Summary --

  * scope: Don't place AM_CONDITIONAL inside a shell condition
  * scope: Use plugin-specific namespace for plugin-specific conditional
  * scope: Cleanup conditional test

-- File Changes --

    M build/scope.m4 (3)
    M utils/src/Makefile.am (2)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/787.patch
https://github.com/geany/geany-plugins/pull/787.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/787

Reply via email to