@elextr I do not understand 'This change will also fail to de-dup paths that are linked to the same file' I thought, the old code did not do that either, but just hashed it into the same bucket.
Diffs looked like http://rb.zq1.de/compare.factory-20180730/glfw-compare.out ```diff --- old//usr/share/geany/tags/glfw.c.tags 2017-02-12 12:00:00.000000000 +0000 +++ new//usr/share/geany/tags/glfw.c.tags 2017-02-12 12:00:00.000000000 +0000 @@ -525,23 +525,23 @@ DN_MULTISHOTÌ65536Ö0 DN_RENAMEÌ65536Ö0 DTTOIFÌ131072Í(dirtype)Ö0 -DT_BLKÌ4Îanon_enum_26Ö0 +DT_BLKÌ4Îanon_enum_29Ö0 DT_BLKÌ65536Ö0 -DT_CHRÌ4Îanon_enum_26Ö0 +DT_CHRÌ4Îanon_enum_29Ö0 DT_CHRÌ65536Ö0 [...] -KHR_xlib_surfaceÌ64Î_GLFWlibrary::anon_struct_20Ö0ÏGLFWbool +KHR_xlib_surfaceÌ64Î_GLFWlibrary::anon_struct_4Ö0ÏGLFWbool ``` So is there any reason against merging this change? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1989#issuecomment-436594032
