@elextr, @b4n: Yes, I reviewed this. I have to admit that I never wrote a 
debugger myself. But the things changed here only apply to the GUI, not to the 
debugger related internals.

I tested the following:
- building under Ubuntu with GTK2 and 3
- simple test under Ubuntu with GTK2 and 3: run a program in the debugger, have 
some breakpoints. Inspect some variables. I clicked some icons and dialogs, 
nothing seems to be broken.
- I did not test the GUI extensively (that means, I did **not** make a 
checkpoint list of all debugger related icons and menus and tested each of it)
- I did not test or build under Windows or Mac
- I had a look at the GTK API calls and the GTK versions for which they are 
supported and suggested changes (see the review for details)
- Changes were applied and I re-tested and re-viewed again

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#issuecomment-444179781

Reply via email to