To be clear, I'm not really opposed to using Github to make edits+PRs[0], I just wanted to see how it worked because I hadn't tried it before and it seemed odd that Github was messing with the main repo in order to make PRs. Now I realize it lets people with push access edit+PR directly on the main repo and doesn't force you to do it on your own fork, which is the only part I don't like much.
[0]: for small text/documentation changes. I do think PRers should at least test code changes themselves on their machine as a minimum bar though (which _was_ done last time), at which point it's no faster re-doing the changes in the online editor instead of just pushing to your fork and making a PR. From this point of view, the online editor isn't terribly useful, IMO. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2035#issuecomment-451311847
