@elextr please don't squash-merge this kind of big PRs with great commit splitting, we now lost the whole history here, and although yes, some commits were big already, most were very well split apart. I'll also make bisecting a potential issue a lot harder.
Anyway, as per the merge itself: I obviously am not a fan, but well, I also admit we need to move forward at some point, and this kind of forces (my) hand. Sad it happens right when I'm back with some time for Geany dev… well I guess them I should have *started* with this one yesterday instead of #2092. > 1. it fixes three languages, Asciidoc, Rest (Geanys own documentation) and > Latex and progresses the process of making it easier to maintain parsers from > upstream. Let's just be fair: I already proposed a standalone fix for Asciidoc and Rest (#2019) without this PR, and you rejected it because merging this was a better choice -- which is fair enough, but then not so much an argument for pushing this one :) I wasn't aware that Latex was broken in master, probably to blame on my lack of Geany time lately. > 2. It has been working for me for months That's a great point :) > 3. If we keep delaying every ctags update for a year we will always have huge > updates :( yes, but with this PR, so long as it can still be merged in Geany, we should have a clean-ish diff from uctags, meaning update should be fairly easy no matter how big they are, as most can just be applied as-is. > The downside is it loses Cobol An ActionScript as well. I don't think we can release in the current state without those, especially as we have at least one active COBOL user that even submitted changes recently. Anyway, we now have to pull up our sleeves and fix what needs to be fixed before the release. Help is welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2018#issuecomment-480483101
