ntrel commented on this pull request.

Providing this works for enough TypeScript code, I think we should merge this.
@jhpratt It would be good to resolve my review points though.

> @@ -0,0 +1,54 @@
+# based on JavaScript file
+# For complete documentation of this file, please see Geany's main 
documentation
+[styling=C]
+
+[keywords]
+# all items must be in one line
+primary=break case catch class const continue debugger default delete do else 
enum export extends extend false finally for function get if import in Infinity 
instanceof let NaN new null return set static super switch this throw true try 
typeof undefined var let while with yield prototype async await declare aliased 
interfaced Alias Interface interface
+secondary=Array Boolean boolean Date Function Math Number number Object String 
string RegExp EvalError Error RangeError ReferenceError SyntaxError TypeError 
URIError constructor prototype decodeURI decodeURIComponent encodeURI 
encodeURIComponent eval isFinite isNaN parseFloat parseInt protected public 
private keyof void any never readonly as

Each of these keyword lists are not sorted properly. I'm not sure if Scintilla 
requires sorted lists for correct operation.

> +comment_use_indent=true
+
+# context action command (please see Geany's main documentation for details)
+context_action_cmd=
+
+[indentation]
+#width=4
+# 0 is spaces, 1 is tabs, 2 is tab & spaces
+#type=1
+
+[build-menu]
+# %f will be replaced by the complete filename
+# %e will be replaced by the filename without extension
+# (use only one of it at one time)
+#FT_02_LB=_Lint
+#FT_02_CM=jshint "%f"

Are there no commands to compile/check a typescript file has valid syntax?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1450#pullrequestreview-247183956

Reply via email to