> I'm not sure forcing a style attribute is a good idea

The style IMO should be whatever string_1 is plus bold. Users who make string_1 
use bold is not something we should worry about, it's not sensible. Adding a 
named style that defaults to `string_1,bold` would work if you prefer the 
override in a central place so weird bold string themes can override it with 
something distinctive ;-)

> Also bold specifically apparently sometimes cause issues with some poor fonts

We already use it for keywords. Those users should fix their fonts.

> I'm pretty sure it was called string_2 to remain generic 

C file type uses it for raw strings. Escape sequences are not raw strings so 
should be styled differently ideally.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2157#issuecomment-504682236

Reply via email to