b4n approved this pull request. Nitpicking below, otherwise looks good :+1:
> +set -e + +TOKENS_CPP_FILE="/tmp/nsis_tokens.cpp" +TOKENS_CPP_URL="https://raw.githubusercontent.com/kichik/nsis/master/Source/tokens.cpp"; +BUILD_CPP_FILE="/tmp/nsis_build.cpp" +BUILD_CPP_URL="https://raw.githubusercontent.com/kichik/nsis/master/Source/build.cpp"; +DATA_FILE=data/filedefs/filetypes.nsis + +[ -f "${DATA_FILE}" ] + +# download tokens.cpp and build.cpp from NSIS +wget --quiet --output-document="${TOKENS_CPP_FILE}" "${TOKENS_CPP_URL}" +wget --quiet --output-document="${BUILD_CPP_FILE}" "${BUILD_CPP_URL}" + +normalize() { + sort | tr '[:upper:]' '[:lower:]' | tr '\n' ' ' | tr '\r' ' ' | sed 's/^[[:blank:]]*//;s/[[:blank:]]*$//' You could merge the `tr` calls like that: `tr '[:upper:][:space:]' '[:lower:] '` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2181#pullrequestreview-253143241
