kugel- commented on this pull request.


> @@ -1375,6 +1375,11 @@ static gboolean on_key_press_event(GtkWidget *widget, 
> GdkEventKey *ev, gpointer
        if (keyval >= GDK_KP_Space && keyval < GDK_KP_Equal)
                keyval = key_kp_translate(keyval);
 
+       if (keyval == GDK_KEY_Escape)
+       {
+               /* close search bar */
+               ui_emit_button_close_in_search_bar_clicked_if_visible(doc);
+       }

Here we should rather have a keybinding. I used to map escape to back, in which 
case, I wouldn't want the search bar to be closed (if the focus is on the 
editor).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2220#pullrequestreview-263499583

Reply via email to