eht16 commented on this pull request.


> +             int wx_root, wy_root, width;
+               window = gtk_widget_get_window (gtk_widget_get_ancestor(widget, 
GTK_TYPE_TOOLBAR));
+#if GTK_CHECK_VERSION(3, 0, 0)
+               gdk_window_get_geometry(window, &wx, &wy, &width, NULL);
+#else
+               gdk_window_get_geometry(window, &wx, &wy, &width, NULL, NULL);
+#endif
+               gdk_window_get_root_coords(window, wx, wy, &wx_root, &wy_root);
+
+#if GTK_CHECK_VERSION(3, 0, 0)
+               gtk_widget_get_preferred_size(widget, &widget_req, NULL);
+#else
+               gtk_widget_size_request(widget, &widget_req);
+#endif
+               /* Approximate the horizontal location of the overflow menu 
button */
+               /* TODO: See if there's a way to find the exact location */

Do you intend to resolve this TODO?
Otherwise we should probably rather describe that there is no known way to get 
the exact position.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/895#pullrequestreview-273420964

Reply via email to