> Sorry, I meant to write disabling notebook tab close buttons.

I didn't even realize that option existed until now. I would guess users who do 
that, it is because they use the keybindings.

> One downside to this is that you have to move the mouse further to click the 
> menu button than before... A simpler solution to this pull would be to move 
> the fixed commands above the notebook tab item list. 

I was going to suggest doing that until I saw this PR for splitting it which 
seems nicer. I personally don't think it's a big deal that you move your mouse 
to a different location.

> But we should also consider frequency of use - I would guess Close would be 
> used more often than Open in New Window.

I would guess the large majority of users don't disable the tab close buttons 
and of those that do, don't use the menu to close tabs. Personally I don't 
think I've _ever_ used to item to close a single document from that menu, 
though I use all of the others often.

> Closing a single document is not a drastic action.

Indeed, but it's more "drastic" than not closing any document.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2348#issuecomment-541259265

Reply via email to