@eht16 commented on this pull request.


> +     gint port_number;
+
+       if (! g_file_test(configfile, G_FILE_TEST_IS_REGULAR))
+       {
+               geany_debug(
+                       "No user config file found, use default TCP port (%s).",
+                       SOCKET_WINDOWS_REMOTE_CMD_PORT);
+               g_free(configfile);
+               return SOCKET_WINDOWS_REMOTE_CMD_PORT;
+       }
+       g_key_file_load_from_file(config, configfile, G_KEY_FILE_NONE, NULL);
+       port_number = utils_get_setting_integer(config, PACKAGE, 
"socket_remote_cmd_port",
+               SOCKET_WINDOWS_REMOTE_CMD_PORT);
+       geany_debug("Using TCP port number %d for IPC", port_number);
+       g_free(configfile);
+       g_key_file_free(config);

Absolutely. At some point I thought adding it and then forgot it :(.
Thanks for reminding me and even do the code :).

I lowered the minimum port value as it seems Windows has no lower boundaries 
for priviledged ports.
Tried port 1 and a few others < 1024 without problems.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2585#discussion_r487581843

Reply via email to