@tivrfoa commented on this pull request.
> + else
+ {
+ gtk_widget_grab_focus(e->file_name);
+ utils_free_pointers(2, project_file_dirname,
locale_filename, NULL);
+ return FALSE;
+ }
> I haven't thought about this much (hence the TODO in my example code), are
> you sure this is the best thing to do?
Yes, I think it is best this way, because it's the same behaviour as for
creating `Base path`.
>
> I get that the path is tested above, but what if the directory is created in
> the meantime (ex. the user leaves the question dialog box up and create the
> directory using their file manager or the terminal)?
>
I just tested the existing logic for `Base path`, and if the directory is
created in the meantime it doesn't recreate the directory. It works. All files
inside the directory were preserved.
> I could be wrong, but it seems like falling back to the old behaviour here
> would be ok, no?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2586#discussion_r489085713
