> @eht16 yay, thanks! I just committed your fix slightly modified to improve > overall ordering of the checks, but it should have the same result.
Confirmed. Your changes work fine ! > @eht16 however, did the bundled regex got used, or did your MSYS have > `regcomp()`? Same question for `fnmathc()`. If MSYS has it, it's less > relevant for us to bundle it, and maybe we should have a way of using that in > the Travis builds instead? ``` ... checking fnmatch.h usability... no checking fnmatch.h presence... no checking for fnmatch.h... no ... checking for regcomp... no ... ``` Full build log with all the boring details at https://gist.github.com/eht16/895090eddc23c6d241eb2cbec25159c0#file-build-log. At the end of the build log is the result of `make check` with all tests failed :(. But luckily this was just because the sample files have LF line endings and the generated tag files have CRLF. As a quick hack I added `--strip-trailing-cr` to `runner.sh` (https://gist.github.com/eht16/895090eddc23c6d241eb2cbec25159c0#file-runner-sh-diff) and the results looked way better. Still a few tests failed. I didn't check why the tests fail but here is the log: https://gist.github.com/eht16/895090eddc23c6d241eb2cbec25159c0#file-test-suite-log -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2666#issuecomment-733978563
