@kugel- approved this pull request. I'm fine with this as-is. More improvements can be done directly on master. I'd rather sail the ship asap.
> @@ -60,9 +60,9 @@ G_BEGIN_DECLS */ #define GEANY_API_VERSION 239 - -/* when gtk2 and gtk3 were both supported at the same time this was used - * to prevent loading gtk2 plugins with gtk3 Geany or vice versa. */ +/* hack to have a different ABI when built with different GTK major versions + * because loading plugins linked to a different one leads to crashes. + * Only GTK3 is currently supported. */ I agree with this, this should be changed (but can be done separately right?) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2602#pullrequestreview-610719346
