@elextr commented on this pull request.
> + delete this;
+ }
+ int SCI_METHOD Version() const override {
+- return lvRelease5;
++ // Geany still uses Lexilla v4
++ //return lvRelease5;
++ return lvIdentity;
+ }
+ const char * SCI_METHOD PropertyNames() override {
+ return osJulia.PropertyNames();
+@@ -173,7 +176,9 @@ public:
+ return 0;
+ }
+
+- static ILexer5 *LexerFactoryJulia() {
++ // Geany still uses Lexilla v4
Technically this is wrong, Geany uses Scintilla 3.5 which is before the
separation of lexilla
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2584#pullrequestreview-692309060