I noticed this does *not* work properly, at least on Windows, maybe also on 
other platforms.
The returned command is not quoted, so if it contains spaces, this will break 
the usage in `utils_open_browser`.

We probably need to quote the command in order to be able to spawn it as 
command line (which we want in case the user wants to add command line 
parameters to the browser setting). I tried `g_shell_quote` but for whatever 
reasons, on Windows it uses single quotes and this does not work with our spawn 
implementation.
`g_app_info_get_commandline` doesn't seem to work on MacOS.

I think I will give up on this here. If someone wants to continue, feel free.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2444#issuecomment-918601467

Reply via email to