@kugel- commented on this pull request.
> @@ -64,17 +68,25 @@ handle_command_line_options() {
"-3")
gtkv="3"
;;
+ "-4")
+ gtkv="4"
I find the mentions of gtk4 weird as it suggest we have any support for it
which is not true.
> @@ -104,6 +104,8 @@ handle_command_line_options() {
}
The patch clearly doesn't match the commit message
> @@ -135,7 +137,8 @@ _getpkg() {
if [ "$use_cache" = "yes" ]; then
package_info=$(pacman -Qi mingw-w64-$ABI-$1)
package_version=$(echo "$package_info" | grep "^Version " | cut
-d':' -f 2 | tr -d '[[:space:]]')
- ls $cachedir/mingw-w64-${ABI}-${1}-${package_version}-* | sort
-V | tail -n 1
+ # use @(gz|xz|zst) to filter out signature files (e.g.
mingw-w64-x86_64-...-any.pkg.tar.zst.sig)
+ ls
$cachedir/mingw-w64-${ABI}-${1}-${package_version}-*.tar.@(gz|xz|zst) | sort -V
| tail -n 1
With `*.tar.{gz,xz,zst}` it should be possible to do without extglob shell
option.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2590#pullrequestreview-761425159
