> Is it a good idea to place these additions both in the Preferences and View > menu ? From what I can tell, many (or most) of the settings in View are > duplicates of those in Preferences. Maybe would be better to have in > Preferences only those that are not directly about Viewing the already-opened > files.
As I said I havn't looked at the changes, but the general principle is that `View` should change the UI layout immediately and the current state be saved and restored, like the checkbox on `Show Message window` etc. > Unless I'm misunderstanding you: code folding enable/disable option is > already present in Preferences To be clear the comment that it is a bad idea was a general one, not specifically aimed at this PR. But it was meant to indicate that therefore the operations in the PR that depend on turning it off are less useful since it should only very rarely be turned off. > I for one would prefer the docs to open in all-folded state (given that it's > not possible/ too hard to implement remembering of folding state) IIUC fold state saving has been folded into (see what I did there ;-) both numbered bookmarks and workbench plugins. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2927#issuecomment-939703551
