@kugel- commented on this pull request.
> @@ -264,6 +279,12 @@ ScintillaGTK::~ScintillaGTK() {
}
ClearPrimarySelection();
wPreedit.Destroy();
+ if (settingsHandlerId) {
+ g_signal_handler_disconnect(settings, settingsHandlerId);
+ }
+ if (settings) {
+ g_object_unref(settings);
Fairly sure this is the problem. `settings` is initialized using
`gtk_settings_get_default()` and this is documented as "transfer-none", so
`g_object_unref()` is inappropriate. Code using this instance is then suffering
from use-after-free.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2930#pullrequestreview-781443527
