@techee commented on this pull request.
> {
- TMSourceFile *hdr = tm_files->pdata[j];
+ TMSourceFile *hdr = tm_files->pdata[0];
gchar **hdr_comps = g_strsplit(hdr->short_name,
".", 2);
>> I'm not sure if @techee wants to use Geany utility function in tagmanager
>> code
> AFAIK there is no "upstream" for tagmanager, and this PR is modifying it
> anyway, so why not.
No problem with using Geany utility functions in TM, I just think that we
should do some bigger Geany-fication of TM code separately (once the TM code
stabilizes and there are no bigger PRs pending - which will hopefully be soon).
So for now I just used the `strrchr()` in the fix. `g_path_get_basename()` gets
called previously already so we don't have to do that here.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3269#discussion_r975352762
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3269/review/[email protected]>
