@eht16 commented on this pull request.
> + log "Signing Geany binary files"
+ for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do
+ for binary_file in $(ls ${binary_file_pattern}); do
+ sign_file ${binary_file}
+ done
+ done
+}
+
+
+convert_text_files_to_crlf() {
+ log "Converting line endings to CRLF in text files"
+ for text_file_pattern in ${GEANY_RELEASE_TEXTFILE_PATTERNS[@]}; do
+ for text_file in $(ls ${text_file_pattern}); do
+ mime_type=$(file --brief --mime-type ${text_file})
+ case $mime_type in text/*)
+ unix2dos ${text_file}
> A tarball created on Linux will have wrong line endings on Windows. The
> normal build system should take care of that instead of being restricted to
> CI.
As said above, if you want to do this, please create an issue or even better a
PR to make the changes to the build system(s). Then we can remove the line
conversion here.
I won't do it because I still think it's not such a big deal and I won't spend
the time effort it needs.
> And how do you create Win32 releases if not using CI (as you mentioned in
> another comment)?
As described on https://wiki.geany.org/howtos/win32/msys2, especially using the
[attached](https://wiki.geany.org/_media/howtos/win32/geany-release.py.txt)
script which also does the line ending conversion to CRLF.
In short, using a clean GIT clone with the release tag. At least with my GIT
config the relevant files all have LF line endings and therefore need to be
converted.
Using a release tarball wouldn't help here because it is created on Linux and
so also has LF line endings.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3315#discussion_r1027082555
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3315/review/1187065...@github.com>
