@b4n requested changes on this pull request.

Looks pretty great, good job! :+1: 
There's just the comment + squashing the commits and it'd look good to go from 
me.  Bonus points if you'd update the documentation though :wink: 

> @@ -3293,6 +3293,22 @@
                                     <property name="position">1</property>
                                   </packing>
                                 </child>
+                                <child>
+                                  <object class="GtkCheckButton" 
id="check_backspace_unindent">
+                                    <property name="label" 
translatable="yes">_Backspace key unindents</property>
+                                    <property name="visible">True</property>
+                                    <property name="can-focus">True</property>
+                                    <property 
name="receives-default">False</property>
+                                    <property name="tooltip-text" 
translatable="yes">With the cursor in the indentation, pressing backspace 
unindents instead of deleting one character</property>
+                                    <property 
name="use-underline">True</property>
+                                    <property 
name="draw-indicator">True</property>
+                                  </object>
+                                  <packing>
+                                    <property name="expand">False</property>
+                                    <property name="fill">False</property>
+                                    <property name="position">1</property>

This should be 2 (3rd child of that container), not 1 like the previous one. As 
is, you can even see the second child in this files appears above the first one.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3355#pullrequestreview-1233154578
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3355/review/[email protected]>

Reply via email to