@elextr commented on this pull request.


>       {
-               gchar *new_cmd = dialogs_show_input(_("Select Browser"), 
GTK_WINDOW(main_widgets.window),
-                       _("Failed to spawn the configured browser command. "
-                         "Please correct it or enter another one."),
+               /* Uses the user's default browser akin to xdg-open (in flatpak 
through a portal) */
+               if (EMPTY(tool_prefs.browser_cmd))
+               {
+                       if 
(gtk_show_uri_on_window(GTK_WINDOW(main_widgets.window), uri, GDK_CURRENT_TIME, 
NULL))

> we're not a chat app or such, we don't present mangled untrusted URIs

Its __worse than that__!!!! If the build command is "builtin" 
`utils_open_browser()` is used to open stuff __I__ wrote :grin: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3178#discussion_r1110394333
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3178/review/[email protected]>

Reply via email to