Because of some problems with the macOS build of git master, I just modified it that instead of cloning the repo it just downloads the current master from https://github.com/geany/geany/archive/refs/heads/master.tag.gz. The tarball, however, doesn't contain a git repository and the build fails with ``` Program python3 found: YES (/Users/jhbuild/gtk/inst/bin/python3) Program rst2html found: NO Program rst2pdf found: NO Program git found: YES (/usr/bin/git) Running command: /usr/bin/git rev-parse --short --revs-only HEAD --- stdout ---
--- stderr --- fatal: not a git repository (or any of the parent directories): .git ../../../../gtk/source/geany-git/meson.build:170:1: ERROR: Command `/usr/bin/git rev-parse --short --revs-only HEAD` failed with status 128. ``` It appears that the problem is the line here which doesn't check if the repo exists (or recovers from the error): https://github.com/geany/geany/blob/2509e21526d36034f5251381a76555e7300fbfc0/meson.build#L170 Once we make a release, the release tarballs will suffer from the same problem so I think it's something that should be fixed. @kugel- Since you are the meson expert, any idea what the best solution of this problem should be? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3424 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/issues/[email protected]>
