@b4n > Actually it [is valid for our purpose at > least](https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gkeyfile.c#L1277).
I already pointed that out [here](https://github.com/geany/geany/pull/3413#issuecomment-1445242422) but as I noted its _not_ documented. Relying on undocumented features seems risky. @techees changes remove that reliance. > set lexer.props.allow.initial.spaces=0 in filetypes.conf, which we probably > shouldn't… Yes we should, to match the parser behaviour you note further on. > For history, the property originates from > https://github.com/geany/geany/commit/00bc23cec4d86d5e18752dc38034978ac18f9645, > which commit message confuses me, as I understand it as meaning the exact > contrary to what it actually does… Well the default value in Scintilla is 1 which matches the comment, but then Geany sets it 0 which is correct (IMNAAHO). > I'm not saying we shouldn't apply your changes here, they do look better to > me. I'm just trying to be (too) thorough. So this is ok and arguing about the lexer prop can occur on another issue/PR, then I agree and LGBI. @techee thank you for doing a boring repetitive job -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3428#issuecomment-1465343587 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3428/[email protected]>
