@b4n commented on this pull request.
> /* retval before function */
g_string_prepend_c(str, ' ');
g_string_prepend(str, retval);
break;
}
+ if (sep)
+ {
+ g_string_append(str, sep);
+ g_string_append(str, retval);
+ }
I'd rather have an if/else here if the value of `sep` is the criteria, like
that I find the code weird as well.
```suggestion
break;
}
if (sep)
{
/* retval after function */
g_string_append(str, sep);
g_string_append(str, retval);
}
else
{
/* retval before function */
g_string_prepend_c(str, ' ');
g_string_prepend(str, retval);
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3463#pullrequestreview-1392638940
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3463/review/[email protected]>
