After some more thinking about it, we can fix #3454 very easily by ourselves by 
checking whether the tag originates from a source file with a known/common 
C/C++ extension - if not, always set "local" to FALSE.

The first patch adds `is_c_source` flag to TMSourceFile to indicate whether the 
file has one of the known C/C++ extensions, the second patch uses this flag and 
for C/C++ sources sets "local" to TRUE only when this flag is set (in 
addition to ctag's isFileScope flag).

@b4n Does this fix look OK to you?

Fixes #3454.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3490

-- Commit Summary --

  * Add a flag to TMSourceFile indicating whether it's a C/C++ source file
  * For C/C++ only mark tag as local if it originates from a source file

-- File Changes --

    M src/tagmanager/tm_ctags.c (7)
    M src/tagmanager/tm_source_file.c (18)
    M src/tagmanager/tm_source_file.h (2)

-- Patch Links --

https://github.com/geany/geany/pull/3490.patch
https://github.com/geany/geany/pull/3490.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3490
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/[email protected]>

Reply via email to