@eht16 requested changes on this pull request. I had a quick look and left a few comments. Though this was no proper review, just a first look.
> @@ -0,0 +1 @@ +Matthew Brush <[email protected]> Maybe add yourself here? > +} + + +/* Load module */ +G_MODULE_EXPORT +void geany_load_module(GeanyPlugin *plugin) +{ + /* Setup translation */ + main_locale_init(LOCALEDIR, GETTEXT_PACKAGE); + + /* Set metadata */ + plugin->info->name = _("Devhelp Plugin"); + plugin->info->description = _("Adds support for looking up documentation in Devhelp, manual pages, and " + "Google Code Search in the integrated viewer."); + plugin->info->version = "1.0"; + plugin->info->author = "Matthew Brush <[email protected]>"; Maybe add yourself here too? > @@ -0,0 +1,240 @@ +#include <stdlib.h> Could you add the file header with the authors and license in all source files? > @@ -0,0 +1,10 @@ +include $(top_srcdir)/build/vars.auxfiles.mk + +if GP_GTK3 What's the use of this switch? :D > @@ -0,0 +1,6 @@ +#!/bin/sh The files: - autogen.sh - config.status - configure - configure.ac - configure.scan - libtool - the whole m4 folder are not necessary at all, just delete them. > @@ -0,0 +1,10 @@ +include $(top_srcdir)/build/vars.docs.mk + +plugin = devhelp + +dist_plugindata_DATA = \ + devhelp-plugin.svg \ + devhelp-plugin-48.png \ + geany-devhelp-plugin.png \ `geany-devhelp.png` is missing here or it is not used and can be removed? > @@ -0,0 +1,1630 @@ +# Doxyfile 1.7.1 Is this file used anywhere? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#pullrequestreview-1553678395 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1242/review/[email protected]>
