> oh wait, that already happens, shows how long since I opened the colour 
> scheme dialog 😁

Yeah, I was going to say that; the color choosing dialog already shows you the 
name (not filename) and description of the theme, so I thought that also 
reading a `mood=` line wouldn't hurt.  It's a big and annoying change anyway 
(all third-party themes would need to be upgraded or risk not being correctly 
classified), hence why I thought there should be some fallback way to detect 
the type.  (In fact, the main use of `mode=` would be for cases where the 
fallback way gives false positives.)

> So ok, a setting like `mode=dark` is possible, but needs code changes to 
> support it, using a setting also complicates sorting (which happens by 
> filename).

Maybe a checkbox like "Show only: [x] light themes, [x] dark themes" is a 
better idea in that regard (exclude/hide non-matching themes rather than 
reordering them).  It'd also "gracefully deal" with themes that are neither 
explicitly light nor dark (they just won't show up when either or both options 
are selected, rather than needing to put them on a "third category" or having 
to guess their type).

> > 🚲 🏠
> 
> [bikeshed](https://thedecisionlab.com/biases/bikeshedding) 

Oooh OK, that was tricky :)
Yeah, I agree that relying on a naming scheme is probably not a good idea, and 
a potential source of disagreement.  Plus, it would mostly only work for themes 
that have a light and a dark version; otherwise I wouldn't expect "light" and 
"dark" in the name.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3566#issuecomment-1742139990
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/issues/3566/[email protected]>

Reply via email to