@eht16 requested changes on this pull request.
On po/ar.po:
Please remove all the translation changes in the *.po files. These are not
necessary in the pull request. The translation files will be updated later as
part of the release process.
> @@ -168,7 +171,7 @@ void templates_replace_common(GString *tmpl, const gchar
> *fname,
NULL);
}
-
+// Maybe a fix to do in this function
It replaces the `{fileheader}` placeholder in other templates when they are
loaded.
As noted below, I think we don't need the "fileheader3" variant at all.
> @@ -501,6 +524,18 @@ gchar *templates_get_template_fileheader(gint
> filetype_idx, const gchar *fname)
return g_string_free(template, FALSE);
}
+// The line `GEANY_API_SYMBOL` is needeed ?
Yes, it would be necessary here as well. This helps the linker to make the
function available for the plugin API.
BUT: I think we don't need the "fileheader3" template at all. It doesn't add
much value as it is the same as "fileheader" but only for GPLv3.
Since the templates are fully user customizable, it is probably enough for
users to modify the existing "fileheader" template or add a new one themselves.
So I suggest to remove the "fileheader3" template altogether.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3549#pullrequestreview-1678765355
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3549/review/[email protected]>
