I think we should switch to using dedicated lexers where these lexers are 
available in Lexilla. This allows better highlighting, where for instance for 
JSON we can color the keys differently from the values and also provide 
optional comment support.

The exact highlighting mapping is open for discussion - I used keys in dicts to 
be colored like keys in conf files but it can be changed to something different.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3647

-- Commit Summary --

  * Convert JSON to builtin filetype and use Scintilla JSON lexer for it

-- File Changes --

    M data/Makefile.am (2)
    D data/filedefs/filetypes.JSON.conf (17)
    A data/filedefs/filetypes.json (59)
    M data/filetype_extensions.conf (2)
    M meson.build (1)
    M scintilla/Makefile.am (1)
    A scintilla/lexilla/lexers/LexJSON.cxx (506)
    M scintilla/lexilla/src/Lexilla.cxx (1)
    M scintilla/scintilla_changes.patch (1)
    M src/editor.c (5)
    M src/filetypes.c (1)
    M src/filetypes.h (1)
    M src/highlighting.c (14)
    M src/highlightingmappings.h (27)

-- Patch Links --

https://github.com/geany/geany/pull/3647.patch
https://github.com/geany/geany/pull/3647.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3647
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/[email protected]>

Reply via email to