@techee commented on this pull request.
> {
- g_warning("Failed to find lexer for ID %u", lexer_id);
+ g_warning("Failed to find lexer for name %s", lexer_name);
> I was wondering whether, now that we use a name for the lexers, if we'd want
> to avoid hard-coding things in highlightingmappings.h and move that to the
> filetypes files à-la-SciTE? E.g. maybe something like this:
That would of course be great. No "built-in" or "external" filetypes, just
builtin lexers and builtin ctags parsers which are configured dynamically in
config files.
The other things like the indexed style definitions would be possible too, it
would just be a little too magic for ordinary users as they don't know what's
at the given index and would have to check the lexer sources.
> But note that any list to check would have to actually be synchronized with
> what is used; the issue in https://github.com/geany/geany/pull/3616 would
> only be found if checking the ID we used, not the list of lexers we had, as
> it was missing from the AddLexerModules() call.
Yes, sure.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3668#discussion_r1382030236
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3668/review/[email protected]>
