1. At [line 3747 of
document.c](https://github.com/geany/geany/blob/e5680fe85de536fc61ff0f2d4eadc54171d6c982/src/document.c#L3747C31-L3747C31)
the value of `doc->priv->file_disk_status` is set to `FILE_OK` **immediately
after it was set to** `FILE_CHANGED`. This seems a bug, possible this glitch
was earlier mentioned in the [comments
here](https://github.com/geany/geany/pull/1180). This information is needed to
implement [reload all](https://github.com/geany/geany/issues/2540), but
disappears too early. (A similar field `doc->changed` nicely updates only when
the text buffer is updated. It has another purpose, I know)
2. Studying the behavior in some more detail I wonder this enumeration type can
be simplified:
```C
typedef enum
{
FILE_OK,
FILE_CHANGED, /* also valid for deleted files */
/* FILE_IGNORE --> Not needed anymore? */
}
FileDiskStatus;
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3711
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/[email protected]>
