> Anyhow, yes, this could be improved, and ideally we'd probably not display 
> the encoding in the list if it's not supported by the library we use (iconv), 
> as it makes little sense then.

Would be nice but IIRC last time we discussed this there was no easy way of 
finding what was supported by `g_convert()`, and does that only use iconv, or 
does it use something else on Windows and Macos?  And even if its iconv all the 
way, there is no programmatic way of determining what it supports.  So probably 
it would involve shell testing `iconv -l` at install time and adapting the 
menu. Too hard.

> So yes, we could display it, it's a Mere Matter of Programming™, to report 
> that error all the way up to the caller that will show the error.

A perfectly good thing to put in a PR called "Various encodings conversion 
fixes" he says hopefully?  Maybe the lowest level function could display the 
message if it was `force` otherwise don't worry about it because its just Geany 
trying all encodings it knows again ;-)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3716#issuecomment-1849117350
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3716/[email protected]>

Reply via email to