@andy5995 I think the main point of @eht16's reply (putting words in his mouth 
:-) was that there are significant differences between the Wiki and your 
filetype, including more keywords in the wiki version, using Python not Sh for 
syntax etc etc so its unclear which is better and how to combine them.  That 
would need to be resolved.  I asked for user 
[comment](https://github.com/geany/geany/issues/3752#issuecomment-1929287021) 
about how well yours works, so that question is now expanded to which is 
better, Dockers please comment.

As for putting it in the Geany release, there have always been debates about 
adding more filetypes, especially for filetypes that no or few Geany devs use, 
so we cannot support or make decisions about the filetypes adequacy.  Each 
language makes the download bigger, adds to the filetype menu, and adds to 
support.  

Personally I have flip/flopped a few times, but given that the "lightweight" 
bird has flown some time ago I don't think the cost of a small file for adding 
a custom filetype is material.  Built-in filetypes are another thing.

The menu issue is harder to address, on small screens large menus may go 
offscreen, and as menus can't be scrolled that means some items can't be 
selected (there have been a number of issues about that).  I don't have a 
solution for this as the Geany categories are hard coded (not that they are 
very good anyway), maybe it should be alphabetical, PRs welcome :grin:.

As for support, thats where the question to the Docker users in general comes 
in, does it work well enough that you are actually going to use it?


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#issuecomment-1937934122
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3757/[email protected]>

Reply via email to