Couple of comments:

1. write the documentation explaining what this plugin is supposed to do, 
sounds like it does something different to what @eht16 understood "pin" to 
mean, and I have always been confused about what it was meant to do.  (and do 
not describe it in terms of some other software, eg do not say "like 
firefox/eclipse/vscode/libreoffice" ;-) [end getting in ahead]  That will mean 
that you can get relevant guidance.

2. relating to https://github.com/geany/geany/pull/3770 and depending on the 
answer to the above, you should be working with notebook pages, not documents.  
I'm pretty sure that plugins can open pages that do not have documents, let 
alone files.

3. And a hint always check `document_valid()` on a document pointer in any 
callback if you pass it via the data pointer, the user can always close pages 
and documents or reorder pages manually.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#issuecomment-1951578796
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1308/[email protected]>

Reply via email to