There was a little more conversation about this in 
https://github.com/andy5995/pinner/commit/8151d8b0b16e4ff3e674d2ad7aaaf97c3b4179f6#commitcomment-138854459

I wanted to mention that if you think is_valid should be 0 when file_name == 
NULL, I'd redo this PR so that happens on 
https://github.com/geany/geany/blob/06acd17cbeab6c0154e752b584aaf5001d9af1e8/src/document.c#L670
 and I'd get rid of the changes currently in this PR.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3770#issuecomment-1955203936
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3770/[email protected]>

Reply via email to