@elextr commented on this pull request.
> +void sci_scroll_lines(ScintillaObject *sci, gint lines)
+{
+ SSM(sci, SCI_LINESCROLL, 0, (uptr_t) lines);
+}
+
+
Disagree with @b4n, all Scintilla interfacing should go through wrappers so
that changes Scintilla makes can be abstracted away, for example the recent
string length change.
The performance difference will be immaterial unless the Scintilla call is
being hammered in a loop (which it never is AFAICT). And if it _is_ a problem
anywhere, define the function `inline` in `sciwrappers.h` (C99).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3835#discussion_r1564399845
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3835/review/[email protected]>
