@elextr commented on this pull request.
> +void sci_scroll_lines(ScintillaObject *sci, gint lines)
+{
+ SSM(sci, SCI_LINESCROLL, 0, (uptr_t) lines);
+}
+
+
@b4n I am normally the one complaining about single use functions where a lump
of functionality is broken out for no good reason, and that case totally
matches your reasoning.
But for APIs wrapping is a useful way of getting encapsulation and hiding, and
the Geany plugin API should have been done that way, but well, that ship has
sailed, hit stormy seas, and sunk ;-D
Probably doesn't matter at this stage which this individual call uses but every
little drop of water erodes the stone [proverb].
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3835#discussion_r1564537916
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3835/review/[email protected]>
