> It was open for a week Availability of our contributors is limited, a week is nowhere near time that guarantees people have time to notice, and review it. Most only have weekends, but if they are busy one weekend they have missed your PR.
> you didn't object to the change after seeing it I suggested an alternative approach and we are looking at that on another PR, that is clearly not approval of this change. > it's an obvious improvement. Because we are looking at an alternative I have not even looked at the implementation of this, so "obvious" is purely your own judgement. It may be right in this case, but it may not be in another. Having someone else review your changes is part of a cooperative project, not merging before they have a chance. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3816#issuecomment-2054023539 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3816/[email protected]>
