@elextr requested changes on this pull request.

LGBI except the ABI thing.

> @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs
        gboolean        use_current_file_dir;   /* find in files directory to 
use on showing dialog */
        gboolean        hide_find_dialog;               /* hide the find dialog 
on next or previous */
        gboolean        replace_and_find_by_default;    /* enter in replace 
window performs Replace & Find instead of Replace */
+       gboolean        skip_confirmation_for_replace_in_session;       /* do 
*not* ask for confirmation

Not last == ABI break as well as API

And if its moved to the end its technically not an API break either since it 
isn't documented for plugin use.

>  **``search`` group**
-find_selection_type               See `Find selection`_.                       
0           immediately
-replace_and_find_by_default       Set ``Replace & Find`` button as default so  
true        immediately
-                                  it will be activated when the Enter key is
-                                  pressed while one of the text fields has
-                                  focus.
+find_selection_type                      See `Find selection`_.                
       0            immediately
+replace_and_find_by_default              Set ``Replace & Find`` button as 
default so  true         immediately
+                                         it will be activated when the Enter 
key is
+                                         pressed while one of the text fields 
has
+                                         focus.
+skip_confirmation_for_replace_in_session If set, do *not* show the             
       false        immediately

If it was lazy me I would have chosen a more cryptic but shorter name to avoid 
indenting the whole table, but since its done might as well leave it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3851#pullrequestreview-2013691773
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3851/review/[email protected]>

Reply via email to